On Wed, Mar 26, 2014 at 08:30:39PM -0400, David Edelsohn wrote: > Okay. > > Good to add the optimizations. > > I notice that you emit nop with a comment after a "#" character. I > notice that you also added that to the POWER8 vector fusion peepholes. > > Is it safe to assume that all assemblers for PowerPC will consider all > characters after a "#" to be a comment?
Well in this case, we are considering only PowerPC assemblers that support VSX. The fusion stuff uses ASM_COMMENT_START, so it should be safe. I can delete the comments on the nop, or delete the nop handling and just do fmr/xxlor to the same register. I put the comments on, so I could tell in processing the asm files which flavor of vec_extract was used (and as I said, on spec 2006, only the fmr/xxlor's were generated, and no nop's). > I would like to make sure there are no other problems with the patch > before backporting to 4.8. It wasn't included in the group of patches > for 4.8 that have been widely tested. I would at least like to add the part that adds vbpermq, even if we don't add the vec_extract optimizations. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797
