On Wed, Feb 26, 2014 at 10:13 PM, Tobias Grosser <tob...@grosser.es> wrote: > On 02/26/2014 10:09 PM, Mircea Namolaru wrote: >> >> This patch fixes the libgomp problems: >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 >> >> 2014-02-26 Tobias Grosser <tob...@grosser.es> >> Mircea Namolaru <mnamo...@inria.fr> >> >> Fix for bug 58028 >> * graphite-clast-to-gimple.c (set_cloog_options): >> Don't remove scalar dimensions >> >> Index: gcc/graphite-clast-to-gimple.c >> =================================================================== >> --- gcc/graphite-clast-to-gimple.c (revision 207298) >> +++ gcc/graphite-clast-to-gimple.c (working copy) >> @@ -1522,6 +1522,13 @@ >> >> variables. */ >> options->save_domains = 1; >> >> + /* Do not remove scalar dimensions. Cloog be default removes scalar >> >> + dimensions very early from the input schedule. However, they are >> + necessary to correctly derive from the saved domains >> + (options->save_domains) the relationship between the generated loops >> + and the schedule dimensions they are generated from. */ >> >> + options->noscalars = 1; >> + >> /* Disable optimizations and make cloog generate source code closer to the >> input. This is useful for debugging, but later we want the optimized >> code. >> >> Tested on x86-64 Linux, no regressions for c/c++/fortran. >> >> Got a notification failure from gcc-patches for the initial submission of >> this >> patch. However, Tobias (on cc) received it and already sent his comments, >> (see http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01540.html), that are >> addressed in this re-submission. > > > Yes, very nice. Thanks Mircea for reacting so quickly. This patch look good > to me. > > @Release-managers: Is this patch OK for trunk?
It fixes a P1 regression, so yes. Richard. > Cheers, > Tobias >
