On Thu, Feb 20, 2014 at 04:44:48PM +0400, Konstantin Serebryany wrote:
> On Thu, Feb 20, 2014 at 4:34 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> > On Thu, Feb 20, 2014 at 01:15:37PM +0100, Jose E. Marchesi wrote:
> >> Yesterday I fetched and built the latest llvm/compiler-rt in sparc64. I
> >> could not manage (in a reasonable time) to get the stuff in
> >> compiler-rt/lib/sanitizer_common and compiler-rt/lib/asan built: these
> >> directories seems to be skipped when compiling on this platform. No, I
> >> am not familiar at all with the llvm/compiler-rt build system. Also I
> >> noticed that there are a lot of changes upstream since last gcc merge
> >> that may or may not compile on sparc: basically constants and data
> >> structures duplicating stuff from kernel headers.
> >
> > Most likely llvm asan isn't supported on sparc, or perhaps even llvm, I
> > think it is not your responsibility to fix it up. So, if the patch is
> > clearly for sparc and doesn't affect anything else, it shouldn't break
> > anything on the llvm side, so I'd hope it should be ok as is to compiler-rt.
>
> We can accept any patch that looks reasonable and does not break our testing.
> We can not promise to keep sparc in usable state as we apply other
> changes (unless you set a public build bot),
> but of course we'll not to break sparc intentionally.
So I think that it is this case. Of course it is possible next merge
from compiler-rt will break sparc again, so I think we should CC affected
target maintainers at that point and let them test/fix it up when that
happens, but that will be post 4.9.
Jakub
