On Thu, Feb 13, 2014 at 10:58 PM, Uros Bizjak <ubiz...@gmail.com> wrote: > You forgot to tell us how the patch tested...
Right. It's a pretty obviously harmless change. I tested that the configure check passes with binutils-2.22, and eyeball'd a -S compile of a trivial function calling __builtin_trap() to see it uses the mnemonic. I don't have ready access to an assembler that does not support the mnemonic, so I simulated the negative case by momentarily hacking configure to try 'ud2x' instead of 'ud2' and verified that this configure check failed and that for the same trivial function it then emits '.value 0x0b0f' as before. > OK for mainline and release branches. Committed to trunk and 4.8. Thanks, Roland