On Wed, Jan 08, 2014 at 04:02:17PM -0700, Jeff Law wrote: > * ree.c (get_sub_rtx): New function, extracted from... > (merge_def_and_ext): Here. > (combine_reaching_defs): Use get_sub_rtx.
> --- a/gcc/ree.c > +++ b/gcc/ree.c > @@ -580,27 +580,17 @@ make_defs_and_copies_lists (rtx extend_insn, const_rtx > set_pat, > return ret; > } > > -/* Merge the DEF_INSN with an extension. Calls combine_set_extension > - on the SET pattern. */ > - > -static bool > -merge_def_and_ext (ext_cand *cand, rtx def_insn, ext_state *state) > +static rtx * > +get_sub_rtx (rtx def_insn) Please add a function comment for it (perhaps saying that it is like single_set but never allows more than one SET). Ok with that change. Jakub