Hi,

On 01/07/2014 07:48 AM, Tim Shen wrote:
I'd prefer to propose another patch that should be commited with this
one, which fix bugs (say _M_flags & regex_constants::icase, not "&&"),
and do more  "matcher optimization".

It is now more DRY (_RegexTranslator<>) and efficient, but <regex>
takes longer to compile, mainly because now we have 4 times more
_Compiler<> versions :)
Ideally, I would suggest committing first the improvements in your previous patch (by the way, thanks for the numbers!) + the pure bug fixes and separate the further performance improvements which have compile-time performance implications (how big?), see if, eg, Jon has something to recommend. Can we do that?

Thanks,
Paolo.


Reply via email to