On Tue, Dec 24, 2013 at 6:38 AM, Allan Sandfeld Jensen <carew...@gmail.com> wrote: > On Monday 23 December 2013, H.J. Lu wrote: >> >> If you use >> >> {"corei7-avx", M_INTEL_COREI7_SANYBRIDGE}, >> {"core-avx2", M_INTEL_COREI7_HASWELL}, >> will it cause any problems? When there are both >> > Actually I seems I don't need these definitions any more after your clean-up > of Intel architecture names. I have attached patch with them removed (and > named haswell enums back to corei7_haswell).
It looks good to me. Thanks. > If both target("arch=corei7-avx") and target("arch=sandybridge") is present > the dispatcher appears to choose "sandybridge". If you want a warning for This is OK with me. > duplicates in this case, I suggest adding it in a later patch. Will libgcc/config/i386/cpuinfo.c update be a separate patch? Should we use a single definition for both i386.c and libgcc? -- H.J.