On Wed, Dec 18, 2013 at 1:57 PM, Allan Sandfeld Jensen
<[email protected]> wrote:
> Update patch. Solved __attribute((target("arch=corei7-avx"))) by defining
> proper architectures for the recent Intel families instead of renaming
> submodels.
@@ -30922,9 +30955,13 @@
F_SSE2,
F_SSE3,
F_SSSE3,
+ F_SSE4_a,
F_SSE4_1,
F_SSE4_2,
F_AVX,
+ F_FMA4,
+ F_XOP,
+ F_FMA,
F_AVX2,
F_MAX
and
@@ -89,9 +97,13 @@
FEATURE_SSE2,
FEATURE_SSE3,
FEATURE_SSSE3,
+ FEATURE_SSE4_a,
FEATURE_SSE4_1,
FEATURE_SSE4_2,
FEATURE_AVX,
+ FEATURE_FMA4,
+ FEATURE_XOP,
+ FEATURE_FMA,
FEATURE_AVX2
};
The above two enums should not be reordered.
> I am thinking the patch is starting to touch a bit many different details,
> perhaps it should be split up, or is it good as is?
It is OK.
Apart from the reordered enums, the patch looks mostly OK. Let's wait
a couple of days for possible comments from Intel and AMD people.
Uros.
