On Tue, Dec 17, 2013 at 08:21:57PM +0100, Thomas Schwinge wrote: > On Mon, 16 Dec 2013 17:58:26 +0100, Jakub Jelinek <ja...@redhat.com> wrote: > > I'd indeed prefer if you just used one > > array, it can be say just uchar array of twice the width, with even chars > > for alignment and odd for kinds (or vice versa), compared to two arrays > > it is tiny bit cheaper at the caller side IMHO. > > Like this, for gomp-4_0-branch? Is hard-coding a shift by eight bits OK, > or am I to fiddle with CHAR_TYPE_SIZE, and the like?
I think shift by 8 bits is fine, I believe 8 bits is the minimum a char can have and it is better if you have a constant you can use on both sides. Jakub