On Fri, Dec 06, 2013 at 06:06:14PM +0100, Kai Tietz wrote:
> --- config/i386/i386.c    (Revision 205719)
> +++ config/i386/i386.c    (Arbeitskopie)
> @@ -10934,18 +10937,21 @@ ix86_expand_prologue (void)
>      }
>        m->fs.sp_offset += allocate;
> 
> +      /* Use stack_pointer_rtx for relative addressing so that code
> +     works for realigned stack, too.  */
>        if (r10_live && eax_live)
>          {
> -      t = choose_baseaddr (m->fs.sp_offset - allocate);
> +      t = plus_constant (Pmode, stack_pointer_rtx, allocate);
>        emit_move_insn (gen_rtx_REG (word_mode, R10_REG),
>                gen_frame_mem (word_mode, t));
> -      t = choose_baseaddr (m->fs.sp_offset - allocate - UNITS_PER_WORD);
> +      t = plus_constant (Pmode, stack_pointer_rtx,
> +                 allocate - UNITS_PER_WORD);

Somebody just asked on IRC whether this shouldn't have been
allocate + UNITS_PER_WORD.

Dunno when would be eax_live true on x86_64 though (except for uninitialized
var uses).

>        emit_move_insn (gen_rtx_REG (word_mode, AX_REG),
>                gen_frame_mem (word_mode, t));
>      }
>        else if (eax_live || r10_live)
>      {
> -      t = choose_baseaddr (m->fs.sp_offset - allocate);
> +      t = plus_constant (Pmode, stack_pointer_rtx, allocate);
>        emit_move_insn (gen_rtx_REG (word_mode,
>                         (eax_live ? AX_REG : R10_REG)),
>                gen_frame_mem (word_mode, t));

        Jakub

Reply via email to