On 12/16/13 08:13, Jeff Law wrote:
On 12/13/13 12:42, Aldy Hernandez wrote:
I'm fixing something completely unrelated, and noticed this...
Perhaps I'm missing something, but why do we need a gate when it always
returns true? Now that we have this `pass_data' business, we can set
has_gate to false.
I also fixed a minor typo in a comment.
Note that the way we handle pass properties differs when we have a gate
vs no gate. See register_dump_files_1.
I have no clue why we have that gem and it looks damn strange to me.
jeff
Ughhh, that's just many shades of wrong. Alright, nice catch. I'll
move onto something else.
Thanks.