On Fri, Dec 13, 2013 at 11:12:03AM +0100, Thomas Schwinge wrote:
> OK to apply the following cleanup patches to trunk, assuming that testing
> (still running) is fine?
> gcc/c/
> * c-parser.c (c_parser_omp_parallel): Fix description.
> gcc/cp/
> parser.c (cp_parser_omp_parallel): Fix description.
Ok.
> Properly order chapters in GCC Internals manual.
>
> gcc/
> * doc/gccint.texi (Top): Fix inclusion order.
Ok.
> Document passes.def.
>
> gcc/
> * doc/cfg.texi (Control Flow): Refer to passes.def instead of
> passes.c.
> * doc/passes.texi (Pass manager): Refer to passes.def.
Ok.
> --- gcc/gimplify.c
> +++ gcc/gimplify.c
> @@ -129,6 +129,8 @@ struct gimplify_ctx
> bool in_cleanup_point_expr;
> };
>
> +/* Variable remapping context. */
Please mention there OpenMP (and after OpenACC support is added, you can
tweak that to OpenMP/ACC or similar (in comments, not in diagnostics of
course).
> +
> struct gimplify_omp_ctx
> {
> struct gimplify_omp_ctx *outer_context;
> @@ -340,7 +342,7 @@ splay_tree_compare_decl_uid (splay_tree_key xa,
> splay_tree_key xb)
> return DECL_UID (a) - DECL_UID (b);
> }
>
> -/* Create a new omp construct that deals with variable remapping. */
> +/* Create a new variable remapping context for REGION_TYPE. */
Ditto, removing omp here loses important information, if you eventually
make it omp/oacc, it will be clear what you are talking about.
> @@ -361,7 +363,7 @@ new_omp_context (enum omp_region_type region_type)
> return c;
> }
>
> -/* Destroy an omp construct that deals with variable remapping. */
> +/* Destroy variable remapping context C. */
Likewise.
> @@ -1715,7 +1718,7 @@ gimplify_var_or_parm_decl (tree *expr_p)
> return GS_ERROR;
> }
>
> - /* When within an OpenMP context, notice uses of variables. */
> + /* Within a variable remapping context, notice uses of variables. */
Likewise.
Many times.
> Reflect reality in comment.
>
> gcc/
> * omp-low.c (check_combined_parallel): Reflect reality in
> comment; from the initial r126226.
Ok (without "; from the initial r126226").
> commit 149ddeaf06affcdd7ed048e0c71b4e02badbf5e9
> Author: Thomas Schwinge <tho...@codesourcery.com>
> Date: Thu Oct 17 21:10:22 2013 +0200
>
> Fix typo in dg-warning comment.
>
> gcc/testsuite/
> * gcc.dg/dfp/wtr-conversion-1.c (testfunc1): Fix typo, from the
> initial r109604.
Ok, but again, ", from the initial r109604" unneeded here.
> Remove leftover comment.
>
> gcc/
> * omp-low.c: Remove leftover comment from function removed in
> r112935.
Ok.
> gcc/
> * tree-pass.h (make_pass_expand_omp_ssa): Remove leftover
> declaration of function removed in r135786.
Ok, but just Remove.
> Remove leftover variable definition.
>
> gcc/
> * omp-low.c (tmp_ompfn_id_num): Remove leftover definition of
Ok, but just Remove.
> variable that is unused as of r160016.
Jakub
