On 12/06/13 01:51, Bernd Edlinger wrote:
As for the patch itself. In a few places within expand_expr_real_1 you
changed calls to expand_expr to instead call expand_expr_real. ISTM
you could have gotten the same effect by just adding your extra argument
to the existing code?
Yes, but one goal is to keep the patch-file as small as possible,
and expand_expr is used everywhere.
Actually expand_expr is just a wrapper for
expand_expr_real (exp, target, mode, modifier, NULL, false)
Sorry, I glossed over that -- mentally I saw the change to expand_expr
and assumed you passed the new flag through. But that's not how the
change is implemented. My bad.
So clearly for the cases where you want the flag to be true, you can't
go through the wrapper. Again, my bad.
jeff
