On Tue, Dec 03, 2013 at 09:05:53AM -0500, David Edelsohn wrote: > On Thu, Nov 21, 2013 at 9:57 PM, Alan Modra <amo...@gmail.com> wrote: > > David, > > Here comes the inevitable followup.. I broke backwards compatibility > > when adding an extra field to ffi_cif. I'd like to import again from > > upstream, where I've already fixed the problem. > > > > https://sourceware.org/ml/libffi-discuss/2013/msg00220.html > > > > Actually, it's not a straight import because many files outside of > > libffi/src/powerpc/ have diverged, but fortunately for me, not > > significantly. For the record, I've shown the files that need > > patching below. Identical patches went in upstream (except for > > formatting differences in Makefile.am). Bootstrapped etc. > > powerpc64-linux and powerpc64le-linux. OK to apply? > > > > libffi/ > > * src/powerpc/ffitarget.h: Import from upstream. > > * src/powerpc/ffi_powerpc.h: Likewise. > > * src/powerpc/ffi.c: Likewise. > > * src/powerpc/ffi_sysv.c: Likewise. > > * src/powerpc/ffi_linux64.c: Likewise. > > * src/powerpc/sysv.S: Likewise. > > * src/powerpc/ppc_closure.S: Likewise. > > * src/powerpc/linux64.S: Likewise. > > * src/powerpc/linux64_closure.S: Likewise. > > * src/types.c: Likewise. > > * Makefile.am (EXTRA_DIST): Add new src/powerpc files. > > (nodist_libffi_la_SOURCES <POWERPC, POWERPC_FREEBSD>): Likewise. > > * configure.ac (HAVE_LONG_DOUBLE_VARIANT): Define for powerpc. > > * include/ffi.h.in (ffi_prep_types): Declare. > > * src/prep_cif.c (ffi_prep_cif_core): Call ffi_prep_types. > > * configure: Regenerate. > > * fficonfig.h.in: Regenerate. > > * Makefile.in: Regenerate. > > * man/Makefile.in: Regenerate. > > * include/Makefile.in: Regenerate. > > * testsuite/Makefile.in: Regenerate. > > Have you tested this patch on targets other than powerpc-linux? Have > you tested this patch on AIX?
I haven't tested on AIX or Darwin, sorry If you find any problems on AIX, please let me know and I'll fix them. I have tested on powerpc-linux, powerpc64-linux, powerpc64le-linux and powerpc-freebsd, which are the targets most affected by this change. I have also bootstrapped and regression tested x86_64-linux gcc with this patch applied. -- Alan Modra Australia Development Lab, IBM
