Hi Jakub,
        Well, it turns out that I need to do a couple more changes than that 
one change in omp-low.c So, please ignore that. I will check in the changes in 
i386.c as obvious since all it involves is removing a '\n.' in the error string.

Thanks,

Balaji V. Iyer.

> -----Original Message-----
> From: Iyer, Balaji V
> Sent: Saturday, November 30, 2013 1:16 PM
> To: Jakub Jelinek
> Cc: Aldy Hernandez (al...@redhat.com); 'gcc-patches@gcc.gnu.org'
> Subject: [GOMP4] SIMD enabled function for C/C++
> 
> Hello Jakub,
>       I was looking at my elemental function for C patch that I fixed up and
> send as requested by Aldy, and I saw two changes there that were used for C
> and C++ and they were pretty obvious. Here are the changes. Can I just
> commit them?
> 
> Thanks,
> 
> Balaji V. Iyer.
> 
> Index: gcc/config/i386/i386.c
> ==========================================================
> =========
> --- gcc/config/i386/i386.c      (revision 205457)
> +++ gcc/config/i386/i386.c      (working copy)
> @@ -43701,7 +43701,7 @@
>           || (clonei->simdlen & (clonei->simdlen - 1)) != 0))
>      {
>        warning_at (DECL_SOURCE_LOCATION (node->decl), 0,
> -                 "unsupported simdlen %d\n", clonei->simdlen);
> +                 "unsupported simdlen %d", clonei->simdlen);
>        return 0;
>      }
> 
> Index: gcc/omp-low.c
> ==========================================================
> =========
> --- gcc/omp-low.c       (revision 205457)
> +++ gcc/omp-low.c       (working copy)
> @@ -12248,6 +12248,9 @@
> 
>    tree attr = lookup_attribute ("omp declare simd",
>                                 DECL_ATTRIBUTES (node->decl));
> +  if (!attr)
> +    attr = lookup_attribute ("cilk plus elemental",
> +                            DECL_ATTRIBUTES (node->decl));
>    if (!attr || targetm.simd_clone.compute_vecsize_and_simdlen == NULL)
>      return;
>    /* Ignore
> 
> 
> Here are the ChangeLogs:
> 
> 2013-11-30  Balaji V. Iyer  <balaji.v.i...@intel.com>
> 
>         * config/i386/i386.c (ix86_simd_clone_compute_vecsize_and_simdlen):
>         Removed a carriage return from the warning string.
>         * omp-low.c (simd_clone_clauses_extract): Added a check for cilk plus
>         SIMD-enabled function attributes.
> 

Reply via email to