On Nov 28, 2013, at 2:03 AM, Chung-Ju Wu <jasonw...@gmail.com> wrote: > There is a pending testsuite patch for nds32 target: > http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01584.html > > Is it OK for trunk? :)
Ok, but please remove: { target nds32*-*-* } from the gcc.target test cases, it is not redundant with the .exp file. A few oddities I will note, if you can improve them… that'd be nice: > +/* { dg-skip-if "Variadic funcs arguments will push by caller for current > nds32 porting." { nds32*-*-* } } */ This is a bit weird. There isn't a notion of current, there isn't a notion of porting. Variadic funcs arguments are caller pushed? > +/* { dg-skip-if "nds32 target has special operations for 64-bit behavior" { > nds32*-*-* } { "*" } { "" } } */ This is a bit weird.