On Wed, Nov 27, 2013 at 10:58:30AM +0100, Richard Biener wrote:
> On Wed, 27 Nov 2013, Tobias Burnus wrote:
> 
> > Am 27.11.2013 08:22, schrieb Sergey Ostanevich:
> > > Done.
> > > 
> > 
> > Thanks for fixing Richard's and Jakub's comments and parts of mine.
> > 
> > > +have the same meaning as described in @option{fvect-cost-model} and by
> > > +default a cost model defined with @option{fvect-cost-model} is used.
> > As mentioned before, pleae add a hyphen before fvect (i.e.
> > "@option{fvect-cost-model}"  -> "@option{-fvect-cost-model}")
> > 
> > Regarding a test case: I still think it would be useful to have one, but I
> > somehow seemed to have messed up with my previous one - I fail to get it not
> > to vectorize with "omp simd" due to cost reasons. Thus, I don't have one.
> 
> Ok with that change - no need to re-post before applying.

Note the start of the ChangeLog is still wrong:

2013-11-25  Sergey Ostanevich  <sergos....@gmail.com>

        * c.opt: Introduced a new openmp-simd warning.
        * lang.opt: Ditto.

Because:

2013-11-25  Sergey Ostanevich  <sergos....@gmail.com>

        * c.opt (Wopenmp-simd): New.

needs to go into the gcc/c-family/ChangeLog and

2013-11-25  Sergey Ostanevich  <sergos....@gmail.com>

        * lang.opt (Wopenmp-simd): New.

needs to go into the gcc/fortran/ChangeLog, you can't use ditto there
because it is a different file.  Please fix that up before committing.

        Jakub

Reply via email to