On 11/25/13 17:29, Kugan wrote:
On 24/11/13 02:14, Ian Lance Taylor wrote:
Kugan <kugan.vivekanandara...@linaro.org> writes:

This RFC patch series implements a simple align divisor shift dividend
method.

Regression tested on arm-none-linux-gnueabi with no issues.

OK?

Thanks,
Kugan

+2013-11-22  Kugan Vivekanandarajah  <kug...@linaro.org>
+
+       * libgcc/libgcc2.c (__udivmoddi4): Define new implementation when
+       HAVE_NO_HW_DIVIDE is defined, for processors without any divide
+     instructions.


The code looks fine to me.

You should document HAVE_NO_HW_DIVIDE in gcc/doc/tm.texi in the Library
Calls section.  The macro should probably be something like
TARGET_HAS_NO_HW_DIVIDE.

Thanks for the review. Is this OK for trunk now?
Yes.  Please install.

jeff

Reply via email to