On 11/20/13 16:48, Cary Coutant wrote:
Sorry, I never saw any feedback, positive or negative, on that, and it
kind of fell off my radar. I think it should still be ready to go in
-- Stage 1 is still open for another day, right? Let me rebase the
patch, kick off a bootstrap and regression tests, and I think I can be
ready to submit it if there are no objections.
Yea, you've still got another day. So definitely rebase and resubmit.
From a review standpoint, things got really bad. If you had something get
dropped, definitely ping it. As a whole, we're doing better now than
probably anytime this year, but as always we could do better.
Sorry, I didn't mean to make it sound like I was blaming any potential
reviewers -- it fell off of my radar (even though I got reminded
occasionally about it by Dehao Chen, who really wants this in trunk).
Totally my failure.
No worries. My views on our patch review backlog are based on a variety
of observations and a few complaints :-) I didn't see your message as a
complaint.
jeff
