On 29 October 2013 15:37, Cesar Philippidis wrote: > This patch addresses two issues with the libstdc++ testsuite: > > * duplicate "-g -O2" CXXFLAGS > * missing "-g -O2" for remote targets > > The duplicate "-g -O2" flags is a result of testsuite_flags.in using > build-time CXXFLAGS and proc libstdc++_init using the environmental > CXXFLAGS, which defaults to its build-time value. This patch prevents > testsuite_flags.in from using build-time CXXFLAGS.
> Certain remote targets require a minimum optimization level -O1 in order > to pass several atomics built-in function tests. This patch ensures > cxxflags contains "-g -O2" at minimum when no other optimization flags > are specified. The testsuite used to set those flags prior to Benjamin's > patch to remove duplicate cxxflags here > <http://gcc.gnu.org/ml/gcc-patches/2012-03/msg01572.html>. > > Is this OK for trunk? If so, please apply (I don't have commit rights). I think so ... although I'm not sure I've got my head round the effects in all cases!