2013/11/20 Joseph S. Myers <jos...@codesourcery.com>: > On Wed, 20 Nov 2013, Ilya Enkovich wrote: > >> Here is a patch to add MPX tests. > > I don't think these should be under gcc.target/i386; gcc.dg/mpx would be > better, so if someone adds a corresponding feature for another target, > they don't need to move all the tests around.
All tests use target specific option -mmpx. Shouldn't it go into target tests then? > > Anything added that's XFAILed should have a comment explaining the reason > for the XFAILing (a reference to a bug in GCC Bugzilla is a good idea, > with that bug then mentioning the particular test that indicates whether > the bug is still present). Tests fail not due to the bug but because these tests should fail. It would mean bound violation was detected. Ilya > > -- > Joseph S. Myers > jos...@codesourcery.com
