On Fri, Nov 15, 2013 at 1:34 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Fri, Nov 15, 2013 at 01:26:54PM -0800, Ian Lance Taylor wrote:
>> Jakub asked whether it would be possible to extend backtrace_syminfo to
>> work for variables as well as functions. It's a straightforward
>> extension, implemented by this patch. Bootstrapped and ran libbacktrace
>> tests on x86_64-unknown-linux-gnu. Any comments on this patch before I
>> submit it?
>
> Looks good to me.
Committed.
> OT,
>
> permanent buffer. If THREADED is non-zero the state may be
> accessed by multiple threads simultaneously, and the library will
> use appropriate locks (this requires that the library be configured
> with --enable-backtrace-threads). If THREADED is zero the state
>
> in backtrace.h in backtrace_create_state comment doesn't look to be
> up to date, there is no --enable-backtrace-threads it seems, just
> depending on configure either it is thread safe or not (and doesn't use
> locks).
Thanks. I committed the following patch to correct the comment.
Ian
2013-11-16 Ian Lance Taylor <i...@google.com>
* backtrace.h (backtrace_create_state): Correct comment about
threading.
Index: backtrace.h
===================================================================
--- backtrace.h (revision 204904)
+++ backtrace.h (working copy)
@@ -89,8 +89,7 @@ typedef void (*backtrace_error_callback)
system-specific path names. If not NULL, FILENAME must point to a
permanent buffer. If THREADED is non-zero the state may be
accessed by multiple threads simultaneously, and the library will
- use appropriate locks (this requires that the library be configured
- with --enable-backtrace-threads). If THREADED is zero the state
+ use appropriate atomic operations. If THREADED is zero the state
may only be accessed by one thread at a time. This returns a state
pointer on success, NULL on error. If an error occurs, this will
call the ERROR_CALLBACK routine. */
