On 11/15/2013 01:05 PM, Janne Blomqvist wrote:
> On Fri, Nov 15, 2013 at 9:11 PM, Jerry DeLisle <jvdeli...@charter.net> wrote:
>> The attached patch sets the create flag for the case where action is
>> specified
>> as read only.
>
> I was looking at this yesterday, but didn't have time to finish
> everything then. So I made a similar patch, which also takes into
> account the case where ACTION= is not specified and opening the file
> with read-write fails and we fall back to trying to open read-only.
>
>> I have confirmed that the PR test case now only produces:
>>
>> open("wombat", O_RDONLY) = 3
>> open("numbat", O_RDONLY) = 4
>> open("dingbat", O_RDONLY) = 5
>
> FWIW, I see you haven't updated recently; since a week ago you should
> also see O_CLOEXEC (unless you have some old system).
I also have the O_CLOEXEC, I just did not paste it in my message.
>
> My alternate patch attached. Regtested on x86_64-unknown-linux-gnu, Ok
> for trunk?
>
OK. Simple enough.
Jerry
