On Thu, 14 Nov 2013, Rainer Orth wrote: > The new gcc.dg/torture/float128* tests FAIL on Solaris 9/x86 which lacks > <fenv.h>. Fixed by the patch below, tested with the appropriate runtest > invocations on i386-pc-solaris2.9 and i386-pc-solaris2.11. > > Ok for mainline?
fenv_exceptions isn't correct for fp-int-convert-float128-timode-3.c, which is about rounding modes, not exceptions. The changes to the other three files are OK. > Btw., the new fenv_exceptions effective-target keywords needs > documenting in sourcebuild.texi. Duplicating documentation for effective-target keywords in sourcebuild.texi seems to me to be a mistake like the documentation for specs in invoke.texi - in both cases, the manual should refer to the source code (making sure the comments are adequate documentation) rather than represent these things as being any sort of interface. It's a bit more reasonable in sourcebuild.texi, being internals documentation (part of the trouble with specs documentation is that it's in the user manual, despite not being meant to be a stable interface), but if it goes there it ought to be automatically extracted from the source code. Most effective-targets added this year don't appear to be in sourcebuild.texi. (That is, sourcebuild.texi should document general features such as dg-require-effective-target, just not the *particular values* that are valid effective-target keywords.) -- Joseph S. Myers jos...@codesourcery.com
