Janne Blomqvist wrote:
the attached patch sets the close-on-exec flag when opening files, as is usually considered good practice these days. See e.g. http://www.python.org/dev/peps/pep-0446/ and links therein for more information.
+ int flags = O_RDWR|O_CREAT|O_EXCL;
I'd add spaces around "|".Otherwise, it looks good to me. Thanks for the patch and sorry for the slow review.
Tobias
