On 11/07/13 10:24, Diego Novillo wrote:
On Thu, Nov 7, 2013 at 5:29 AM, Richard Biener
<richard.guent...@gmail.com> wrote:
Moved to fold-const.c:
size_low_cst
Same as int_cst_value just with lack of any checking?
It may be. It's used by the POINTER_EXPR_PLUS handler. I will try to
replace it in a later patch.
Moved to gimple-fold.c:
truth_type_for (maybe keep extern?)
Uses a langhook so should stay here.
Done.
Moved to tree-ssa-dom.c:
iterative_hash_exprs_commutative
I'm not sure - it seems that iterative_hash_expr does exactly
the same thing? So instead of moving things this should
be refactored (make that function re-usable from iterative_hash_expr).
Future patch? Making it static will at least prevent diverging uses of
the similar functions.
I think future patch. In theory we ought to just make
iterative_hash_exprs_commutative just go away, but there's some
restructuring of the DOM code that would need to happen first.
jeff
