On Thu, Nov 07, 2013 at 07:17:19AM +0000, Nathan Sidwell wrote:
> On 11/06/13 21:25, Dodji Seketeli wrote:
> >It appeared that gcov.c and input.c both have a static function named
> >read_line. I guess we ought to keep just one.
>
> As a general rule, that's good.
Generally yes, but IMHO not in this case, both because of the problems you
are mentioning, because it already now needs to do quite different things
and because I think in the future the version for caret diagnostics should
do much more complicated things (caching of the lines for faster further
caret diagnostics). Furthermore, ftell/fseek aren't something that should
be used unless strictly necessary.
Jakub
