On Tue, 2013-11-05 at 08:19 +0100, Jakub Jelinek wrote:
> On Mon, Nov 04, 2013 at 05:48:31PM -0800, Konstantin Serebryany wrote:
> > Hi Peter.
> > Does this also mean that asan in llvm trunk is broken for Power?
> > We'll need to fix it there too (or, in fact, first).
>
> I bet on all targets, not just PPC. By including kernel headers directly,
> you are entering very hairy maze of kernel header issues. So, for testing
> that you probably need to grab /usr/include/{linux,asm*} trees from various
> popular Linux distros (and various versions thereof), and do compile tests
> against all of those.
>
> Note, not even glibc itself includes <asm/stat.h>, so the chances of that
> header actually working for you are low. glibc instead just defines the
> structures itself for each of the architectures.
I have to agree, including kernel header files is always frowned upon
and very risky. Jakub, do you think we should be doing the same thing
here that glibc does, namely having libsanitizer defining its own
structures?
Peter
