On Mon, Nov 04, 2013 at 09:22:39AM -0700, Aldy Hernandez wrote: > Ok, then let's leave this for later. I'm following what we've done > in tree-sra.c to be consistent. Perhaps later we could even clean > up ipa_sra_modify_function_body in tree-sra.c. But for now I think > we can concentrate on the basic functionality.
Well, ipa_sra_modify_function_body doesn't need to regimplify, unlike the omp-low.c version thereof (supposedly because SRA only modifies loads/stores, but doesn't change SSA_NAMEs on arithmetics etc.). But yeah, this isn't requirement for hacking on this on gomp-4_0-branch, but it would be nice to clean it up before merging to trunk. > Committing to omp4 branch. Thanks. Jakub