On Thu, 31 Oct 2013, Ilya Enkovich wrote:

>       * tree-chkp.c: New.

This file includes tm.h.  Inclusion of tm.h in front-end and GIMPLE files 
is discouraged (well, we'd like to convert all target macros to hooks, but 
the limited subset used in front-end and GIMPLE files are lower-hanging 
fruit than eliminating tm.h from the RTL parts of the compiler).  If you 
need it, please put a comment on the #include saying exactly what target 
macros you need, so people know which macros' conversion to hooks would 
eliminate the need for the tm.h inclusion.

>       * tree.h (DECL_BOUNDS_RTL): New.
>       (SET_DECL_BOUNDS_RTL): New.
>       (DECL_BOUNDS): New.
>       (SET_DECL_BOUNDS): New.
>       (chkp_get_rtl_bounds): New.

A lot of work is in progress to split up catch-all headers such as tree.h 
and to get source files to include only those headers they need.  I'm 
doubtful that all these chkp_* declarations really belong in such a 
widely-included header.  I'd think it would be better to put them in a 
tree-chkp.h header and include that header only in those source files that 
need it.

(Of course, if any function isn't needed outside tree-chkp.c, make it 
static.  The header is only for those functions that are actually used in 
at least one other source file.)

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to