On Sep 28, 2013, at 5:40 AM, Joern Rennecke <joern.renne...@embecosm.com> wrote: > This patch adds a number of tests for ARC target specific options. > > I'm a bit uncertain here if I still need approval for this patch.
No, it is not required. Target maintainers can approve the usual tests suite patches. Everything in gcc.target/<target> certainly are in this set. They typical changes to .exp for target supports for example are fine, as are the typical patches in existing test cases to declare things like small stacks, low memory, no common support, 16 bit porting, 32 bit porting and so on… if in doubt, ask, we endeavor to be responsive to patches. > On the one hand the changes are all in an area that is normally within > the remit of a target maintainer, and patch to add the gcc.target/arc > directory has already been accepted. Though, technically, it should go in as the port goes in. :-) I did review the patch anyway, Ok.
