> FWIW, I'd prefer to keep it as-is, since must_be_base_p (x) and > must_be_index_p (x) don't imply that we should look specifically at > XEXP (x, 0) (rather than just X, or XEXP (x, 1), etc.). I think it's > better to keep the code tests and the associated XEXPs together.
Feel free to revert this part, but then add appropriate comments explaining why we are interested in LO_SUM for set_address_base and in MULT and the 5 others for set_address_index. If it's because the former is rather a base than an index and vice-versa for the latter, then it's even clearer with the predicates I think. -- Eric Botcazou
