On Thu, Sep 12, 2013 at 09:33:05AM +0100, Andrew Haley wrote: > On 09/12/2013 03:11 AM, Alan Modra wrote: > > We have precedent for compiling libffi based on gcc preprocessor > > defines, eg. __NO_FPRS__, so here's a way of making upstream libffi > > compatible with the various versions of gcc out there. I've taken the > > condition under which we align aggregates from > > rs6000_function_arg_boundary, and defined a macro with a value of the > > maximum alignment. > > I would have thought that a runtime or configure-time test in libffi > would be better.
I don't see how a runtime check can be done, and a configure test just adds another layer of indirection. How is testing a cpp macro at configure time better than testing the same at compile time? -- Alan Modra Australia Development Lab, IBM