On Wed, 2013-09-11 at 10:32 +0200, Richard Biener wrote: > On Tue, Sep 10, 2013 at 5:53 PM, Yufeng Zhang <yufeng.zh...@arm.com> wrote: > > Hi, > > > > Following Bin's patch in > > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00695.html, this patch tweaks > > backtrace_base_for_ref () to strip of any widening conversion after the > > first TREE_CODE check fails. Without this patch, the test > > (gcc.dg/tree-ssa/slsr-39.c) in Bin's patch will fail on AArch64, as > > backtrace_base_for_ref () will stop if not seeing an ssa_name since the tree > > code can be nop_expr instead. > > > > Regtested on arm and aarch64; still bootstrapping x86_64. > > > > OK for the trunk if the x86_64 bootstrap succeeds? > > Please add a testcase.
Also, the comment "Strip of" should read "Strip off". Otherwise I have no comments. Thanks, Bill > > Richard. > > > Thanks, > > Yufeng > > > > gcc/ > > > > * gimple-ssa-strength-reduction.c (backtrace_base_for_ref): Call > > get_unwidened and check 'base_in' again. >
