On Fri, 6 Sep 2013 11:30:53, Jakub Jelinek wrote: > On Fri, Sep 06, 2013 at 11:28:44AM +0200, Eric Botcazou wrote: >>> this patch fixes the ICE and wrong code issues from PR57748. It contains two >>> test cases. One for the ICE and one for the wrong code. Both test cases >>> fail for all gcc versions, and are fixed with this patch. >>> >>> Bootstrapped and tested on x86_64-linux without any problems. >>> >>> OK for trunk and the 4.8 / 4.7 branch? >> >> Please avoid touching the 4.7 branch at this point, this is a sensitive area >> and the testcases look quite artificial to me. > > Even for 4.8 it needs at least several weeks on the trunk before considering > backports of such code. > > Jakub
That's true, the examples are quite artificial, because it is difficult and quite target-dependent, if there will be a movmisalign optab at all. And the original test case will no longer reproduce on trunk because of this change: 2013-08-08 Bernd Edlinger <bernd.edlin...@hotmail.de> PR target/58065 * config/arm/arm.h (MALLOC_ABI_ALIGNMENT): Define. maybe we should first backport this one. Yesterday someone did that on the linaro branch, but maybe /branches/gcc-4_8-branch should be updated as well? Bernd.