Ping? Could somebody please review this for me? -- Caroline Tice cmt...@google.com
On Wed, Aug 28, 2013 at 2:15 PM, Caroline Tice <cmt...@google.com> wrote: > Discussion on this topic seems to have petered out. I have removed > references to ENABLE_VTABLE_VERIFY from libvtv, as requested. I > cannot remove them from libgcc, as they really need to be there. I > have updated the documentation in install.texi, as requested. > Please review the attached patch, which does all of this, and let me > know if it is ok to commit. > > -- Caroline Tice > cmt...@google.com > > gcc ChangeLog: > > 2013-08-28 Caroline Tice <cmt...@google.com> > > * doc/install.texi: Add documentation for the --enable-vtable-verify > and the --disable-libvtv configure options. > > libvtv ChangeLog: > 2013-08-28 Caroline Tice <cmt...@google.com> > > * Makefile.am: Remove #if ENABLE_VTABLE_VERIFY checks around > definitions of SUBDIRS, libvtv_la_SOURCES and libvtv_include_HEADERS. > * Makefile.in: Regenerate. > * configure.ac: Remove checks and tests for --enable-vtable-verify. > * configure: Regenerate. > > On Thu, Aug 8, 2013 at 3:11 PM, Joseph S. Myers <jos...@codesourcery.com> > wrote: >> On Thu, 8 Aug 2013, Caroline Tice wrote: >> >>> The attached patch adds documentation for the --enable-vtable-verify >>> configure option to install.texi. Is this ok to commit? >> >> Could you please answer the questions I raised in the first four >> paragraphs of <http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00427.html> at >> greater length? This patch appears to document it just as a libstdc++ >> configure option, but as noted there it appears to affect more than >> libstdc++ (even though it would be more sensible if it *only* affected >> libstdc++, and even better if it just enabled extra multilibs). >> >> -- >> Joseph S. Myers >> jos...@codesourcery.com
