> -----Original Message----- > From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] > Sent: Tuesday, August 13, 2013 7:18 AM > To: Iyer, Balaji V > Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek > (pola...@redhat.com) > Subject: Re: [PATCH] Fix for PR c/57490 > > Hi Iyer, > > > First off, my sincerest apologies for letting this bug slip the cracks. > > I am > attaching a patch that seem to work fine with the .i file that you have > submitted > in bugzilla for both C and C++. Please let me know if this fix works for you > and if > it is OK for trunk. > > thanks for the patch. I've just bootstrapped it on i386-pc-solaris2.10 and > all an- > if.c failures are gone. That said, I wonder why we need the separate > pr57490.c > testcase, which is practically a preprocessed version of an-if.c with the > HAVE_IO > code removed.
Well, it has assert in it. A while back someone (I think it was Jason Merrill, but I could be wrong) told me to replace all asserts with builtin_abort. But the content inside the file is the same. > > I cannot approve the patch, though. > OK. Can I ask why? Is it because you do not have an authority or is it because you see some errors (e.g. formatting errors) in it? If it is the latter, can you tell me what the errors are so that I can go and fix them? > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University
