> On Fri, Aug 9, 2013 at 11:33 AM, Jan Hubicka <hubi...@ucw.cz> wrote: > >> Is this version ok for trunk? > > > > It looks resonable, but I still do not like much the removal of const for > > tables. > > Doing so will push them all into David Malcom's per-thread global universe. > > > > Currently the algorithm is selected based on cost->memset/cost->memcpy. > > Instead of removing the const of all the CPU tables, I would preffer > > introducing two readwrite global variables memset_algs/memcpy_algs and feed > > them with proper table at a time we set up ix86_tune_features. > > > > I can do that in this patch. In the future, when we need to do tunings > for those constants, we can revisit it.
Yep, I think we can follow same strategy and just move them to a global constant. Those are part of the context/universum since they will be user rewritable then. Thanks, the patch is OK with this change. Honza > > thanks, > > David > > > This has chance to do the right thing with optimize attribute specifying > > algorithms > > and with the longer term threading plan. > > > > Honza > >> > >> thanks, > >> > >> David > >> > >> On Thu, Aug 8, 2013 at 9:31 AM, Xinliang David Li <davi...@google.com> > >> wrote: > >> > Updated. > >> > > >> > thanks, > >> > > >> > David > >> > > >> > On Thu, Aug 8, 2013 at 8:18 AM, Joseph S. Myers > >> > <jos...@codesourcery.com> wrote: > >> >> On Wed, 7 Aug 2013, Xinliang David Li wrote: > >> >> > >> >>> Updated patch attached (fixed header, buffer overflow, and warning --> > >> >>> error problems). > >> >> > >> >> You still have diagnostics starting with a capital letter, contrary to > >> >> the > >> >> GNU Coding Standards. > >> >> > >> >> -- > >> >> Joseph S. Myers > >> >> jos...@codesourcery.com
