Ping? Is it OK for 4.8 and trunk? Thanks! -Zhenqiang
On 1 August 2013 10:04, Zhenqiang Chen <zhenqiang.c...@linaro.org> wrote: > Thank you all for the comments. The patch is updated as: > 1) Revert it to the original one. > 2) For the testcase, replace the dg-options with > /* { dg-do compile } */ > /* { dg-require-effective-target arm_neon } */ > /* { dg-add-options arm_neon } */ > /* { dg-options "-O3" } */ > > Bootstrap on Chromebook and Pandaboard. > No make check regression on Pandaboard. > > Thanks! > -Zhenqiang > > On 9 July 2013 02:49, Jakub Jelinek <ja...@redhat.com> wrote: >> On Mon, Jul 08, 2013 at 11:44:04AM -0700, Janis Johnson wrote: >>> >> @@ -0,0 +1,16 @@ >>> >> +/* { dg-do compile } */ >>> >> +/* { dg-options "-O3 -mfpu=neon -mcpu=cortex-a9 -mthumb >>> >> -mfloat-abi=hard -S" } */ >>> >> >>> >> dg-add-options arm_neon ? >>> >> dg-require-effective-target arm_neon ? >>> > >>> > I will update it. >>> >>> Please skip the test for multilibs whose flags include -mfpu or -mcpu >>> options, >>> which would conflict with or override the options in the test. >> >> Also the -S in dg-options looks wrong. That should be derived from dg-do. >> >> Jakub