> The usual x86 ports avoid this, because their must_return_in_mem hooks DTRT
> already and we never fall into the default case.

So why not do the same for i686-elf?

> I am very surprised this hasn't bitten someone before -- I presume this
> never worked with i686-elf.  It is possible this'll change some other ABI
> where a fixed reg was permitted to be used in the manner that this now
> prohibits, but I have a hard time thinking that happens.  Shout if you
> know of one.

IMO that's not sufficient, you ought to go through all the back-ends and check 
that you aren't breaking anything with such a bold change.  This code is more 
than 2 decades old and can affect every single port in a major way.

-- 
Eric Botcazou

Reply via email to