Maxim, thank you for your input! That's for sure a better solution. __BIONIC__ is not defined in features.h so I had to change the include to ctype.h. (__BIONIC__ is defined in sys/ctypes.h, but it's not safe to include that directly..)
tested on x86_64_unknow_linux and on android device. Is it OK? thanks, Alexander 2013/7/14 Maxim Kuvyrkov <ma...@kugelworks.com>: > On 13/07/2013, at 10:34 AM, Mike Stump wrote: > >> On Jun 20, 2013, at 4:30 AM, Alexander Ivchenko <aivch...@gmail.com> wrote: >>> for Android: >> >>> +2013-06-19 Alexander Ivchenko <alexander.ivche...@intel.com> >>> + >>> + * g++.dg/tls/thread_local4.C: Disable test for Android. >>> + * g++.dg/tls/thread_local4g.C: Ditto. >> >>> is it ok for trunk? >> >> Ok. > > Alexander, > > Your current patch as approved by Mike is OK, but it is more prudent to > condition the tests on using Bionic libc, not the fact that target triplet > has *-android* in it. [E.g., it is possible to build a toolchain for, say, > arm-linux-gnueabi which will use glibc for primary multilib, and bionic for > secondary multilib.] > > I didn't test the attached patch, so please confirm that it behaves as > expected before applying it. > > Thank you, > > -- > Maxim Kuvyrkov > KugelWorks >
nonbionic_target.patch
Description: Binary data
