On Wed, Jul 24, 2013 at 4:49 AM, Rainer Orth
<r...@cebitec.uni-bielefeld.de> wrote:
> Ian Lance Taylor <i...@google.com> writes:
>
>> On Thu, Jul 18, 2013 at 6:59 AM, Rainer Orth
>> <r...@cebitec.uni-bielefeld.de> wrote:
>>> Ian Lance Taylor <i...@google.com> writes:
>>>
>>>> I have committed a large patch to update libgo to the library that was
>>>> part of the Go 1.1.1 release. As usual, I'm not including the entire
>>>> patch in this e-mail message, because it is too large. I'm only
>>>> including the changes to the files that are partially gccgo-specific.
>>>> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.
>>>> Committed to mainline and 4.8 branch.
>>>
>>> This broke the Solaris build:
>>>
>>> /vol/gcc/src/hg/trunk/local/libgo/go/log/syslog/syslog_libc.go:18:25:
>>> error: use of undefined type 'serverConn'
>>> func unixSyslog() (conn serverConn, err error) {
>>> ^
>>> make[6]: *** [log/syslog.lo] Error 1
>>>
>>> Didn't make much progress on this one.
>>
>> The interface I put in a while back for Solaris support got taken out
>> from the master library, and I missed it. This patch restores it.
>> Committed to mainline and 4.8 branch. I've also sent a patch to the
>> master library to restore the interface.
>
> Thanks, that allowed libgo.so to build on Solaris 10/x86.
> Unfortunately, all tests FAIL like this:
>
> Undefined first referenced
> symbol in file
> runtime_unminit
> /var/gcc/regression/trunk/10-gcc/build/i386-pc-solaris2.10/amd64/libgo/.libs/libgo.so
> runtime_minit
> /var/gcc/regression/trunk/10-gcc/build/i386-pc-solaris2.10/amd64/libgo/.libs/libgo.so
> runtime_mpreinit
> /var/gcc/regression/trunk/10-gcc/build/i386-pc-solaris2.10/amd64/libgo/.libs/libgo.so
> ld: fatal: symbol referencing errors. No output written to a.out
> collect2: error: ld returned 1 exit status
> FAIL: bufio
>
> I've fixed this by also adding the definitions of those three functions
> to runtime/thread-sema.c, although there might be a better way to handle
> this:Sorry, that was really sloppy of me. I just moved those functions to runtime.c instead. I committed this patch to mainline and 4.8 branch. Ian
foo.patch
Description: Binary data
