On Mon, 8 Jul 2013, Ondrej Bilka wrote: > Hi now, when I have infrastructure ready I made another patch (its 500kb so > link not to overload list). It is here; > http://kam.mff.cuni.cz/~ondra/gcc_misspell_conventions.patch > > It uses dictionary made by reading gcc conventions. > http://gcc.gnu.org/codingconventions.html
As explained on that page, certain files and directories come from upstream and so it is inappropriate to apply GCC-specific conventions to them, or to fix any typos locally rather than upstream. In particular, you should not be patching boehm-gc or zlib. intl is also externally maintained code so again should not be patched for this issue; likewise libdecnumber and libffi (libdecnumber and libffi may get local patches, but only when needed to fix bugs, not simply for GCC-specific conventions). libiberty is shared with other projects so it's not clear that GCC-specific conventions should apply there; you need to discuss changes there in conjunction with the other projects. libjava/classpath and libjava/libltdl are also externally maintained. libquadmath code comes from glibc so unless the code in question is GCC-specific, do not apply GCC conventions to it. It's possible that the changes do make sense for the other projects, in that the GCC conventions are supposed to have good reasons behind them. But, you should raise the issues with those projects separately and if patches are desired only then produce patches relative to current upstream versions of those projects. It is not generally desirable to apply such cleanups to testcases. -- Joseph S. Myers jos...@codesourcery.com
