On Thu, 4 Jul 2013, Joern Rennecke wrote:

> Quoting "Joseph S. Myers" <jos...@codesourcery.com>:
> 
> > On Thu, 4 Jul 2013, Joern Rennecke wrote:
> > 
> > > For this fix I've assumed that it is now the job of the various places
> > > that
> > > do calculations with sizetypes to flag overflows where this is desired.
> > 
> > Integer constants may be shared, I don't think setting TREE_OVERFLOW on
> > existing constants like you do is necessarily safe.
> 
> Hmm, indeed.  I now added a copy_node call in set_init_index to avoid this
> problem.  For complete_array_type, we need this information just a bit
> further thon in the function, so I just made it a boolean flag.
> 
> > Also note c/ and c-family/ have their own ChangeLog files.
> 
> Oops. I though I checked that.  Foiled by ls localisation.
> 
> I'm currently testing the attached updated patch.

This is OK if it passes testing.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to