On 06/19/2013 10:02 AM, Bernhard Reutner-Fischer wrote:
On 19 June 2013 15:57, Jeff Law <l...@redhat.com> wrote:
On 06/19/2013 01:02 AM, Chung-Ju Wu wrote:
2013/6/19 Jeff Law <l...@redhat.com>:
* gcc.dg/tree-ssa/forwprop-28.c: New test.
In the gnu coding standard we have a space before
the open-parentheses. Would that be great to have
testcase follow this convention as well? :)
If so, then...
No reason not to fix the test in this instance. I'll make these updates
before committing.
eh, nitpicking party ?
+ If a simplification is mode, return TRUE, else return FALSE. */
+static bool
+simplify_bitwise_binary_boolean (gimple_stmt_iterator *gsi,
s/mode/made/
Fixed via attached patch.
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 0ecf5ba..bd60452 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,8 @@
2013-06-19 Jeff Law <l...@redhat.com>
+ * tree-ssa-forwprop.c (simplify_bitwise_binary_boolean): Fix typo
+ in comment.
+
* tree-ssa-forwprop.c (simplify_bitwise_binary_boolean): New function.
(simplify_bitwise_binary): Use it to simpify certain binary ops on
booleans.
diff --git a/gcc/tree-ssa-forwprop.c b/gcc/tree-ssa-forwprop.c
index 29a0bb7..df19295 100644
--- a/gcc/tree-ssa-forwprop.c
+++ b/gcc/tree-ssa-forwprop.c
@@ -1881,7 +1881,7 @@ hoist_conversion_for_bitop_p (tree to, tree from)
then we can simplify the two statements into a single LT_EXPR or LE_EXPR
when code is BIT_AND_EXPR and BIT_IOR_EXPR respectively.
- If a simplification is mode, return TRUE, else return FALSE. */
+ If a simplification is made, return TRUE, else return FALSE. */
static bool
simplify_bitwise_binary_boolean (gimple_stmt_iterator *gsi,
enum tree_code code,
