On Thu, Jun 13, 2013 at 11:37 AM, Alan Modra <amo...@gmail.com> wrote:

> Revised patch with offsettable_ok_by_alignment change, avoiding dumb
> idea of using statement expressions.  This one actually bootstraps and
> passes regression testing.
>
>         * config/rs6000/rs6000.h (enum data_align): New.
>         (LOCAL_ALIGNMENT, DATA_ALIGNMENT): Use rs6000_data_alignment.
>         (DATA_ABI_ALIGNMENT): Define.
>         (CONSTANT_ALIGNMENT): Correct comment.
>         * config/rs6000/rs6000-protos.h (rs6000_data_alignment): Declare.
>         * config/rs6000/rs6000.c (rs6000_data_alignment): New function.

The revised patch, without the DECL_P part is okay.

The original code produced the necessary alignment and neither of us
can find any code in public packages that increases the alignment for
PPC vector types.  While there is the possibility that a user could
encounter an object file produced by an older GCC with less strict
alignment and a version of GCC with this fix would make an incorrect
assumption, this does not seem very likely in practice.

Thanks, David

Reply via email to