> >>> The target_cpu_canonical substitution has been added in commit > >>> 369e542b3ad1c0acfa9bfaeb72b338d8db5ba2ef (2009-02-27, r144463, > >>> schwab) but unused ever since, thus removed. > >>> > >>> I'll now be testing for x86 GNU/Linux and GNU/Hurd; further > >>> testing appreciated. > > For these two configurations, I have now successfully tested the > > patch I posted. Further review/testing appreciated. (Adding > > »build machinery (*.in)« maintainers.) > > > > > > I agree that using $(target_os) and linux% matches is a better way to > strip out the "-gnu"s. > > The patch is long, but I think I reviewed it carefully enough. It's > okay for mainline.
Not so fast, we are talking about the Ada build machinery which requires an Ada maintainer to review it. The patch seems to go in the right direction but needs careful review which hasn't been done yet, so please hold on your change for now, thanks. In other words, this change will impact basically all targets, so needs either much more testing, or more review, which is on going. Arno