-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 29/05/2013 12:50, Thomas Schwinge ha scritto: >>> How about we use something like the following [...] patch? In >>> essence, replace the manual parsing in >>> gcc/ada/gcc-interface/Makefile.in by using the values the >>> configure script already computed for us. This is largely >>> straightforward (I would hope); please especially review the >>> more involved cases such as the one where I'm now using >>> linux%eabi -- for example, does that do the right thing or >>> interfere with the Android configurations? >>> >>> The target_cpu_canonical substitution has been added in commit >>> 369e542b3ad1c0acfa9bfaeb72b338d8db5ba2ef (2009-02-27, r144463, >>> schwab) but unused ever since, thus removed. >>> >>> I'll now be testing for x86 GNU/Linux and GNU/Hurd; further >>> testing appreciated. > For these two configurations, I have now successfully tested the > patch I posted. Further review/testing appreciated. (Adding > »build machinery (*.in)« maintainers.) > >
I agree that using $(target_os) and linux% matches is a better way to strip out the "-gnu"s. The patch is long, but I think I reviewed it carefully enough. It's okay for mainline. Regarding the android change: > -ifeq ($(strip $(filter-out arm%-linux,$(arch)-$(osys)) $(if > $(findstring eabi,$(word 4,$(targ))),,$(word 4,$(targ)))),) +ifeq > ($(strip $(filter-out arm% linux%eabi,$(target_cpu) > $(target_os))),) This is okay, it will match arm-none-linux-androideabi both before and after (perhaps linux-%eabi would be more readable). However, it seems that the first androideabi snippet was dead code. Can you delete it in a follow-up? Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRpg7xAAoJEBvWZb6bTYbyEKgP/RI1fU8fEdzH1UK+3BG8sqgF DSoK0mo25PBIGHYT8p4Qe2a9tE2fZys93NHufPmQnVQ1M/YqmB5JyspCoe0mqke0 fQUMI8DpV0f+g9MquIZFDYrceR4qGEaFZ9KlnHGcpErA5zs1Wb7Shj6SoWt4I3b3 2dQy61hD7DcVe1xctG349xU6Hc2j34VCk8axUcpFCm9iD6UBB8GAUmZCk6egkIJr BWs9anasAhmh1E4aEOjGFvhWQcB23pmxSkIIk5wSkKBHZpHURIwXqOUmK1I0ebme j7ee2+9SzSwk0emY4lBdDg14byVSvRMKnMDpFdIfHTJvYEqm6ha8jeNxBKqM/xvk pz7AX1jwfsX22QSWiZuqcqqYBR0y7qVA0/5rjyFitLB85PY+yIfe5BNH4d5KdeuF yDuss+n6vZrYCnyRpk0P4VbLQ5gnrtqDhxTKPABf3eMNFI6iyyadRh0qLQVrnyX5 qmUciuZTMouC4rAx1H/oAAHZbPmeHWS6cH7ggO0WlS5Us/Ws/s3OdFUePygXhQpL xpOgqjSaDhE6s4PQAZkX79EOqvtEJynX/gGi3NTyZey/Fsp9n5JFperjAUfPG/Bt 2Cu7tDmcXLKlNKeaL7IuLppVPmVicfXTUAnYemWja78ijbbKLeD2W5OGzsfxTMuV QoH7oqV2NqSIayTAmYg6 =Sh4D -----END PGP SIGNATURE-----
