Mike Stump <m...@mrs.kithrup.com> writes:
> On May 28, 2013, at 3:56 PM, Dehao Chen <de...@google.com> wrote:
>> The attached patch restricts the test only run on linux-gnu targets. Is it
>> ok?
>
> Ok. You can put HAVE_AS_DWARF2_DEBUG_LINE in a comment above it to help
> explain why the target restriction applies. The idea is, if enough people
> care, or some x86 target (say, darwin), want to reliably find them all, one
> can then search for that and fix them all in one go.
Right, this does work e.g. on Solaris/x86 with gas, but fails with Sun
as or Darwin as.
Btw., why is this even x86 specific? At least on Solaris/SPARC with
gas, HAVE_AS_DWARF2_DEBUG_LINE *is* defined.
And why do you add -gdwarf-2 in dg-options? AFAICS all tests in
gcc.dg/debug/dwarf2 are built with -gdwarf-2 anyway. Perhaps you need
just { dg-additional-options "-O0" } instead?
Also, please mention PR testsuite/57413 in the ChangeLog and move the
addition of the testcase from gcc/ChangeLog to gcc/testsuite/ChangeLog,
removing the testsuite/ prefix in the pathname.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
