On Wed, May 22, 2013 at 9:55 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Tue, May 21, 2013 at 07:03:54PM +0200, Uros Bizjak wrote: >> This patch avoids movdqu/movdqa when SSE2 is disabled. Although >> -mno-sse2 is bordering on ABI violation for 64bit targets, the patch >> is simple enough to fix movti_internal_rex64 pattern. > > If the TImode attr variant isn't valid for !SSE2, I'd find it clearer > to do > (match_test "!TARGET_SSE2") (const_string "V4SF") > much earlier in the cond, before TARGET_AVX case that returns TImode > (sure, when TARGET_AVX is true, then !TARGET_SSE2 is false), and > not added using ior to an unrelated condition.
Yes, this is a good suggestion, I was trying to be consistent with the movti_internal pattern. I will change both in the way you suggested ASAP. Thanks, Uros.
